Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Handle<T: UiMaterial> as a component #15720

Closed
tim-blackbird opened this issue Oct 8, 2024 · 0 comments · Fixed by #15740
Closed

Stop using Handle<T: UiMaterial> as a component #15720

tim-blackbird opened this issue Oct 8, 2024 · 0 comments · Fixed by #15740
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use

Comments

@tim-blackbird
Copy link
Contributor

See #15716
@tim-blackbird tim-blackbird added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Oct 8, 2024
@tim-blackbird tim-blackbird mentioned this issue Oct 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@tim-blackbird
Replace Handle<M: UiMaterial> component with UiMaterialHandle wra…
9aef71b 
…pper (#15740)

# Objective

- Closes #15720

## Solution

Wrap the handle in a new wrapper component: `UiMaterialHandle`
It's not possible to match the naming convention of `MeshMaterial3d/2d`
here with the trait already being called `UiMaterial`

Should we consider renaming to `Material3d/2dHandle` and `Mesh3d/2d` to
`Mesh3d/2dHandle`?

- This shouldn't have any merge conflicts with #15591

## Testing

Tested the `ui_material` example

## Migration Guide

Let's defer the migration guide to the required component port. I just
want to yeet the `Component` impl on `Handle` in the meantime :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Handle<M: UiMaterial> component with UiMaterialHandle wrapper tim-blackbird/bevy
1 participant
@tim-blackbird