-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Labels
A-PickingPointing at and selecting objects of all sortsPointing at and selecting objects of all sortsC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Milestone
Description
Originally found with the bevy::plugin_not_ending_in_plugin
lint.
There are 3 plugins introduced by bevy_picking
that do not have a Plugin
suffix:
MeshPickingBackend
SpritePickingBackend
DefaultPickingPlugins
1 and 2 should be renamed to follow the style of MeshPickingBackendPlugin
or MeshPickingPlugin
, while 3 should not even be a plugin, but instead a PluginGroup
(like DefaultPlugins
).
Given how all 3 of these types were added after 0.14 was released, their names are not yet public. (Excluding the release candidate.) This means that we still have a chance to rename them before they become introduced to other projects, avoiding breaking changes in the future.
tim-blackbird and MihaiZegheru
Metadata
Metadata
Assignees
Labels
A-PickingPointing at and selecting objects of all sortsPointing at and selecting objects of all sortsC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or changeD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!