Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename animated fox examples to better communicate their purpose #17192

Closed
alice-i-cecile opened this issue Jan 6, 2025 · 5 comments · Fixed by #17239
Closed

Rename animated fox examples to better communicate their purpose #17192

alice-i-cecile opened this issue Jan 6, 2025 · 5 comments · Fixed by #17239
Labels
A-Animation Make things move and change over time C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

I like the split a lot, but I think we should rename these examples to not refer to foxes. That's an implementation detail that doesn't matter to learners :)

Originally posted by @alice-i-cecile in #17191 (review)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples A-Animation Make things move and change over time S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jan 6, 2025
@BenjaminBrienen
Copy link
Contributor

Why not rename them in that PR? If it gets merged as-is, I'll pick this up.

@alice-i-cecile
Copy link
Member Author

Just timing with the merge train.

@greeble-dev
Copy link
Contributor

@BenjaminBrienen, I can pick this up if you like. Asking because I want to make some follow up changes to the examples, and I figure this issue is best resolved first.

@greeble-dev greeble-dev mentioned this issue Jan 8, 2025
Merged
@rparrett
Copy link
Contributor

rparrett commented Jan 8, 2025

Not opposed to renaming, but I (maybe irrationally) like the animated_fox naming. It sets itself apart from the other bare-bones animation examples and implies that there's a character / skeleton involved.

github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2025
@greeble-dev
Rename animated fox examples to better communicate their purpose (#17239
Loading
Loading status checks…
6462935 
)

Fixes #17192.

Replaces "animated_fox" with "animated_mesh".

I considered a few different names - should it say "skinned_mesh" to be
precise? Should it mention gltf? But "animated_mesh" seems intuitive and
keeps it short.

## Testing

- Ran all three examples (Windows 10).
@greeble-dev
Copy link
Contributor

@rparrett agreed, although I got some comfort from the website examples page still having a screenshot of the fox. For my follow up PR I could maybe tweak the description to say "Plays an animation from a skinned glTF model of a fox".

Image

mrchantey pushed a commit to mrchantey/bevy that referenced this issue Feb 4, 2025
@greeble-dev @mrchantey
Rename animated fox examples to better communicate their purpose (bev…
cf4816e 
…yengine#17239)

Fixes bevyengine#17192.

Replaces "animated_fox" with "animated_mesh".

I considered a few different names - should it say "skinned_mesh" to be
precise? Should it mention gltf? But "animated_mesh" seems intuitive and
keeps it short.

## Testing

- Ran all three examples (Windows 10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename animated fox examples to better communicate their purpose greeble-dev/bevy
4 participants
@rparrett @alice-i-cecile @BenjaminBrienen @greeble-dev