Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heap corruption in par_for_each_mut #1943

Closed
TheLeonsver1 opened this issue Apr 16, 2021 · 0 comments
Closed

Heap corruption in par_for_each_mut #1943

TheLeonsver1 opened this issue Apr 16, 2021 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention

Comments

@TheLeonsver1
Copy link

TheLeonsver1 commented Apr 16, 2021 •
edited
Loading

Bevy version

0.5

Operating system & version

Windows 10

What you did

I tried to do query.par_for_each_mut() in my app,
The function that causes the heap corruption is here: https://github.com/TheLeonsver1/sprite_editor/blob/heap_corruption_repro_two/src/systems/initializing.rs#L94
The reproduction is in this branch:
https://github.com/TheLeonsver1/sprite_editor/tree/heap_corruption_repro_two

To cause the crash you need to click on File -> New -> Insert in Tile:256,256 and in Tileset:50,50

What you expected to happen

The function to run normally (initialize a vector of a certain size and assign it to the component of the entity)

What actually happened

Crash with HEAP_CORRUPTION error, TheRawMeatball also reproduced

Additional information

Already mentioned in "What you did"
@TheLeonsver1 TheLeonsver1 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 16, 2021
@TheRawMeatball TheRawMeatball added A-ECS Entities, components, systems, and events P-High This is particularly urgent, and deserves immediate attention and removed S-Needs-Triage This issue needs to be labelled labels Apr 16, 2021
@mockersf mockersf mentioned this issue Apr 16, 2021
Closed
@bors bors bot closed this as completed in 2bd8ed5 Apr 19, 2021
@mockersf mockersf mentioned this issue May 24, 2021
Closed
ostwilkens pushed a commit to ostwilkens/bevy that referenced this issue Jul 27, 2021
@mockersf @ostwilkens
par_for_each: split batches when iterating on a sparse query (bevyeng…
5d19de7 
…ine#1945)

Fixes bevyengine#1943 

Each batch was iterating over the complete query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-High This is particularly urgent, and deserves immediate attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - par_for_each: split batches when iterating on a sparse query mockersf/bevy
2 participants
@TheRawMeatball @TheLeonsver1