Skip to content

DynamicBundle::Effect is now (almost) vestigial #20979

@james7132

Description

@james7132

Does it still make sense to have Effect as an associated type here? It doesn't seem like it actually gets used, apart from the NoBundleEffect trait bound, which could be moved to Self. We should certainly leave it there for now to make this change smaller, but we may want to remove it as a follow up.

Originally posted by @chescock in #20772 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-ECSEntities, components, systems, and eventsC-Code-QualityA section of code that is hard to understand or changeS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions