-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Res<Assets<T>>.is_changed()
is true every frame, even when not changed
#2275
Comments
TheLeonsver1
added
C-Bug
An unexpected or incorrect behavior
S-Needs-Triage
This issue needs to be labelled
labels
May 29, 2021
TheLeonsver1
changed the title
May 29, 2021
Res<Assets<T>>.is_selected()
is true every frame, even when not changedRes<Assets<T>>.is_changed()
is true every frame, even when not changed
alice-i-cecile
added
A-Assets
Load files from disk to use for things like images, models, and sounds
and removed
S-Needs-Triage
This issue needs to be labelled
labels
May 29, 2021
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this issue
Jul 27, 2021
## Objective - Fixes: bevyengine#2275 - `Assets` were being flagged as 'changed' each frame regardless of if the assets were actually being updated. ## Solution - Only have `Assets` change detection be triggered when the collection is actually modified. - This includes utilizing `ResMut` further down the stack instead of a `&mut Assets` directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
0.5
Operating system & version
Windows 10
What you did
checked if my assets changed
What you expected to happen
for it to only be triggered once after the assets were changed.
What actually happened
Res<Assets<T>>.is_changed()
triggered every frame without even changing assetsThe text was updated successfully, but these errors were encountered: