QueryCombinationIter should not implement ExactSizeIterator #5846
Labels
A-ECS
Entities, components, systems, and events
C-Bug
An unexpected or incorrect behavior
C-Code-Quality
A section of code that is hard to understand or change
D-Trivial
Nice and easy! A great choice to get started with Bevy
M-Needs-Migration-Guide
A breaking change to Bevy's public API that needs to be noted in a migration guide
Comments
nicopap
added
C-Bug
alice-i-cecile
added
the
D-Trivial
|
I've implemented this fix in #5895. I'm new to rust/bevy so any help with improving the PR will be appreciated! |
james7132
pushed a commit
to james7132/bevy
that referenced
this issue
Oct 28, 2022
# Objective - `QueryCombinationIter` can have sizes greater than `usize::MAX`. - Fixes bevyengine#5846 ## Solution - Only the implementation of `ExactSizeIterator` has been removed. Instead of using `query_combination.len()`, you can use `query_combination.size_hint().0` to get the same value as before. --- ## Migration Guide - Switch to using other methods of getting the length.
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this issue
Dec 17, 2022
# Objective - `QueryCombinationIter` can have sizes greater than `usize::MAX`. - Fixes bevyengine#5846 ## Solution - Only the implementation of `ExactSizeIterator` has been removed. Instead of using `query_combination.len()`, you can use `query_combination.size_hint().0` to get the same value as before. --- ## Migration Guide - Switch to using other methods of getting the length.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this issue
Feb 1, 2023
# Objective - `QueryCombinationIter` can have sizes greater than `usize::MAX`. - Fixes bevyengine#5846 ## Solution - Only the implementation of `ExactSizeIterator` has been removed. Instead of using `query_combination.len()`, you can use `query_combination.size_hint().0` to get the same value as before. --- ## Migration Guide - Switch to using other methods of getting the length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bevy version
QueryCombinationItercan very easily have a length greater thanusize::MAX, therefore shouldn't implementExactSizeIterator.Know length iterators with potential greater-than-
usize::MAXlength instd::iteranditertoolsdo not implementExactSizeIterator, because the value oflencannot be accurate if the length exceedsusize. (iter::Repeat,iter::Intersperse,itertools::Product,itertools::Combinationsdo not implementExactSizeIterator)The text was updated successfully, but these errors were encountered: