Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui scroll behaviour is funky #6287

Closed
ickk opened this issue Oct 18, 2022 · 3 comments
Closed

Ui scroll behaviour is funky #6287

ickk opened this issue Oct 18, 2022 · 3 comments
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior
Milestone
Bevy 0.9

Comments

@ickk
Copy link
Member

ickk commented Oct 18, 2022 •
edited
Loading

As with #6272 the Ui coordinate system changes from #6000 have caused the Ui scroll behaviour to be flipped. Noticeable in the ui example.
image
@ickk ickk added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Oct 18, 2022
@ickk
Copy link
Member Author

ickk commented Oct 18, 2022

Aside from scrolling in the wrong direction, when a line of text is partially visible it aligns to the bottom which is incorrect/different to the prior behaviour
image

@ickk ickk mentioned this issue Oct 18, 2022
Closed
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets and removed S-Needs-Triage This issue needs to be labelled labels Oct 18, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.9 milestone Oct 18, 2022
@TimJentzsch
Copy link
Contributor

This should be closed as per #6290.

@ickk
Copy link
Member Author

ickk commented Oct 19, 2022

No, the issue in #6287 (comment) remains

@mockersf mockersf mentioned this issue Oct 23, 2022
Closed
@bors bors bot closed this as completed in a3ca184 Oct 24, 2022
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@mockersf @james7132
Fix clipping in UI (bevyengine#6351)
3b5e298 
# Objective

- Clipping (visible in the UI example with text scrolling) is funky 
- Fixes bevyengine#6287 

## Solution

- Fix UV calculation:
  - correct order for values (issue introduced in bevyengine#6000)

  - add the `y` values instead of subtracting them now that vertical order is reversed
  - take scale factor into account (bug already present before reversing the order)
- While around clipping, I changed clip to only mutate when changed

No more funkiness! 😞 

<img width="696" alt="Screenshot 2022-10-23 at 22 44 18" src="https://user-images.githubusercontent.com/8672791/197417721-30ad4150-5264-427f-ac82-e5265c1fb3a9.png">
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this issue Dec 17, 2022
@mockersf @Pietrek14
Fix clipping in UI (bevyengine#6351)
dfcb3c0 
# Objective

- Clipping (visible in the UI example with text scrolling) is funky 
- Fixes bevyengine#6287 

## Solution

- Fix UV calculation:
  - correct order for values (issue introduced in bevyengine#6000)

  - add the `y` values instead of subtracting them now that vertical order is reversed
  - take scale factor into account (bug already present before reversing the order)
- While around clipping, I changed clip to only mutate when changed

No more funkiness! 😞 

<img width="696" alt="Screenshot 2022-10-23 at 22 44 18" src="https://user-images.githubusercontent.com/8672791/197417721-30ad4150-5264-427f-ac82-e5265c1fb3a9.png">
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@mockersf @ItsDoot
Fix clipping in UI (bevyengine#6351)
2587049 
# Objective

- Clipping (visible in the UI example with text scrolling) is funky 
- Fixes bevyengine#6287 

## Solution

- Fix UV calculation:
  - correct order for values (issue introduced in bevyengine#6000)

  - add the `y` values instead of subtracting them now that vertical order is reversed
  - take scale factor into account (bug already present before reversing the order)
- While around clipping, I changed clip to only mutate when changed

No more funkiness! 😞 

<img width="696" alt="Screenshot 2022-10-23 at 22 44 18" src="https://user-images.githubusercontent.com/8672791/197417721-30ad4150-5264-427f-ac82-e5265c1fb3a9.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix clipping in UI mockersf/bevy
3 participants
@alice-i-cecile @TimJentzsch @ickk