Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to run on Ubuntu Latest #6832

Closed
hymm opened this issue Dec 3, 2022 · 3 comments
Closed

Update CI to run on Ubuntu Latest #6832

hymm opened this issue Dec 3, 2022 · 3 comments
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior

Comments

@hymm
Copy link
Contributor

hymm commented Dec 3, 2022

Recently the ubuntu image in CI updated from 20.04 to 22.04. This broke the run-examples and run-examples-on-wasm actions. As a temporary fix, the images used for these actions was changed to use ubuntu-20.04 instead of ubuntu-latest. It is likely that the packages that need to be installed to get these actions to run correctly has changed. Someone should figure out the new requirements and switch ci back to ubuntu-latest.

Info

Error for run-examples action:

Run for example in .github/example-run/*.ron; do
running alien_cake_addict - Thu Dec 1 00:19:11 UTC 2022
xvfb-run: error: Xvfb failed to start

real	0m0.6[18](https://github.com/bevyengine/bevy/actions/runs/3588188694/jobs/6039310786#step:8:19)s
user	0m0.021s
sys	0m0.045s
Error: Process completed with exit code 1.

Error for run-examples-on-wasm:

Run cd .github/start-wasm-example

added 3 packages, and audited 4 packages in 5s

found 0 vulnerabilities
Installing dependencies...
Switching to root user to install dependencies...
Hit:1 https://packages.microsoft.com/ubuntu/22.04/prod jammy InRelease
Hit:2 http://azure.archive.ubuntu.com/ubuntu jammy InRelease
Hit:3 http://azure.archive.ubuntu.com/ubuntu jammy-updates InRelease
Hit:4 http://azure.archive.ubuntu.com/ubuntu jammy-backports InRelease
Hit:5 http://azure.archive.ubuntu.com/ubuntu jammy-security InRelease
Hit:6 https://ppa.launchpadcontent.net/oibaf/graphics-drivers/ubuntu jammy InRelease
Hit:7 https://ppa.launchpadcontent.net/ubuntu-toolchain-r/test/ubuntu jammy InRelease
Reading package lists...
Reading package lists...
Building dependency tree...
Reading state information...
Package ttf-ubuntu-font-family is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package ttf-unifont is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  fonts-unifont

Package libicu66 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'ttf-unifont' has no installation candidate
E: Package 'ttf-ubuntu-font-family' has no installation candidate
E: Unable to locate package libenchant1c2a
E: Package 'libicu66' has no installation candidate
E: Unable to locate package libvpx6
E: Unable to locate package libwebp6
Failed to install browsers
Error: Installation process exited with code: [10](https://github.com/bevyengine/bevy/actions/runs/3588188694/jobs/6039310786#step:7:11)0
Error: Process completed with exit code 1.
@hymm hymm added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled A-Build-System Related to build systems or continuous integration and removed S-Needs-Triage This issue needs to be labelled labels Dec 3, 2022
@rparrett
Copy link
Contributor

rparrett commented Dec 4, 2022

For the run-examples part:

Here's some more verbose error output: xvfb.log

I believe this is related: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7819

Adding

env:
  LIBGL_ALWAYS_SOFTWARE: true

To the workflow seems to be fix the issue.

AdapterInfo { name: "llvmpipe (LLVM 15.0.5, 256 bits)", vendor: 65541, device: 0, device_type: Cpu, driver: "llvmpipe", driver_info: "Mesa 23.0.0-devel (git-77ecf91 2022-12-03 jammy-oibaf-ppa) (LLVM 15.0.5)", backend: Vulkan }

For the run-examples-on-wasm, it looks like we need to upgrade to playwright >1.23. microsoft/playwright#13738

@oliviacrain
Copy link
Contributor

Will work on the playwright upgrade for run-examples-on-wasm!

@oliviacrain
Copy link
Contributor

Actually, I'll take both- run-examples should be fixed on 22.04 now. The PPA we pull mesa components from just released a version with the upstream fix.

@bors bors bot closed this as completed in b58ca87 Dec 8, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
…bs (bevyengine#6875)

# Objective

- The `run-examples-on-wasm` job fails on Ubuntu 22.04, when it was previously working on Ubuntu 20.04. Playwright 1.22.1 (the version currently pinned by us) fails trying to install system dependencies that were renamed between Ubuntu 20.04 and 22.04.
- The `run-examples` job previously failed on Ubuntu 22.04 with errors consistent with those listed in [this upstream mesa bug](https://gitlab.freedesktop.org/mesa/mesa/-/issues/7819).
- Fixes bevyengine#6832

## Solution

- Upgrade `playwright` to the latest [v1.28.1](https://github.com/microsoft/playwright/releases/tag/v1.28.1) release. Ubuntu 22.04 support was [added](microsoft/playwright#14588) in [v1.23.0](https://github.com/microsoft/playwright/releases/tag/v1.23.0). The [test now passes on 22.04](https://github.com/oliviacrain/bevy/actions/runs/3633583112/jobs/6130757397), and the output screenshots are unchanged from previous job outputs.
- Use `ubuntu-latest` for the `run-examples` job. No other modifications necessary. The [PPA we pull mesa from](https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers) rebuilt the package for 22.04 with the [upstream fix](https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20145/diffs?commit_id=b3d1ae19f2f4d93cf0a5f45a598149ac4e8e05aa).
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
…bs (bevyengine#6875)

# Objective

- The `run-examples-on-wasm` job fails on Ubuntu 22.04, when it was previously working on Ubuntu 20.04. Playwright 1.22.1 (the version currently pinned by us) fails trying to install system dependencies that were renamed between Ubuntu 20.04 and 22.04.
- The `run-examples` job previously failed on Ubuntu 22.04 with errors consistent with those listed in [this upstream mesa bug](https://gitlab.freedesktop.org/mesa/mesa/-/issues/7819).
- Fixes bevyengine#6832

## Solution

- Upgrade `playwright` to the latest [v1.28.1](https://github.com/microsoft/playwright/releases/tag/v1.28.1) release. Ubuntu 22.04 support was [added](microsoft/playwright#14588) in [v1.23.0](https://github.com/microsoft/playwright/releases/tag/v1.23.0). The [test now passes on 22.04](https://github.com/oliviacrain/bevy/actions/runs/3633583112/jobs/6130757397), and the output screenshots are unchanged from previous job outputs.
- Use `ubuntu-latest` for the `run-examples` job. No other modifications necessary. The [PPA we pull mesa from](https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers) rebuilt the package for 22.04 with the [upstream fix](https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20145/diffs?commit_id=b3d1ae19f2f4d93cf0a5f45a598149ac4e8e05aa).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants