Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GizmoPlugin: AABBs are rendered with one frame lag #9156

Closed
LeshaInc opened this issue Jul 14, 2023 · 2 comments · Fixed by #9166
Closed

GizmoPlugin: AABBs are rendered with one frame lag #9156

LeshaInc opened this issue Jul 14, 2023 · 2 comments · Fixed by #9166
Labels
A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Milestone
0.11.1

Comments

@LeshaInc
Copy link
Contributor

Bevy version

0.11.0

What went wrong

AABBs are rendered with one frame lag, which is noticeable when objects are moving.

Additional information

GizmoPlugin is not configuring draw_aabb and draw_all_aabbs systems properly. They read GlobalTransform and thus should run after TransformSystem::TransformPropagate
@LeshaInc LeshaInc added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 14, 2023
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Gizmos Visual editor and debug gizmos and removed S-Needs-Triage This issue needs to be labelled labels Jul 14, 2023
@Selene-Amanita Selene-Amanita added this to the 0.11.1 milestone Jul 15, 2023
@wpederzoli wpederzoli mentioned this issue Jul 15, 2023
Merged
@wpederzoli
Copy link
Contributor

@LeshaInc @alice-i-cecile @Selene-Amanita I pushed a change for this issue but I see some CI jobs were cancelled and I am not able to re-run them. Please let me know if I'm missing something

@alice-i-cecile
Copy link
Member

Nothing on your end there: I've rerun them for you.

github-merge-queue bot pushed a commit that referenced this issue Jul 23, 2023
@wpederzoli
gizmo plugin lag bugfix (#9166)
593bebf 
# Objective
Fixes #9156
cart pushed a commit that referenced this issue Aug 10, 2023
@wpederzoli @cart
gizmo plugin lag bugfix (#9166)
891acb8 
# Objective
Fixes #9156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
0.11.1
Development

Successfully merging a pull request may close this issue.

gizmo plugin lag bugfix wpederzoli/bevy
4 participants
@alice-i-cecile @wpederzoli @LeshaInc @Selene-Amanita