Replace EntityMap with regular HashMap
#9321
Labels
A-ECS
Entities, components, systems, and events
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
D-Trivial
Nice and easy! A great choice to get started with Bevy
Comments
Shatur
added
C-Feature
Selene-Amanita
added
D-Trivial
Aztro-dev
added a commit
to Aztro-dev/bevy
that referenced
this issue
Aug 4, 2023
…, implementing Deref and DerefMut for EntityMap
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 28, 2023
# Objective - Fixes #9321 ## Solution - `EntityMap` has been replaced by a simple `HashMap<Entity, Entity>`. --- ## Changelog - `EntityMap::world_scope` has been replaced with `World::world_scope` to avoid creating a new trait. This is a public facing change to the call semantics, but has no effect on results or behaviour. - `EntityMap`, as a `HashMap`, now operates on `&Entity` rather than `Entity`. This changes many standard access functions (e.g, `.get`) in a public-facing way. ## Migration Guide - Calls to `EntityMap::world_scope` can be directly replaced with the following: `map.world_scope(&mut world)` -> `world.world_scope(&mut map)` - Calls to legacy `EntityMap` methods such as `EntityMap::get` must explicitly include de/reference symbols: `let entity = map.get(parent);` -> `let &entity = map.get(&parent);`
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this issue
Jan 9, 2024
# Objective - Fixes bevyengine#9321 ## Solution - `EntityMap` has been replaced by a simple `HashMap<Entity, Entity>`. --- ## Changelog - `EntityMap::world_scope` has been replaced with `World::world_scope` to avoid creating a new trait. This is a public facing change to the call semantics, but has no effect on results or behaviour. - `EntityMap`, as a `HashMap`, now operates on `&Entity` rather than `Entity`. This changes many standard access functions (e.g, `.get`) in a public-facing way. ## Migration Guide - Calls to `EntityMap::world_scope` can be directly replaced with the following: `map.world_scope(&mut world)` -> `world.world_scope(&mut map)` - Calls to legacy `EntityMap` methods such as `EntityMap::get` must explicitly include de/reference symbols: `let entity = map.get(parent);` -> `let &entity = map.get(&parent);`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
EntityMapcontainsHashMapunder the hood. I think it was created to make it easier to handle errors in theMapEntitiestrait and have methods that returns by value instead of by reference.Introducing new map-like methods (like #9291) require passing the manually.
What solution would you like?
MapEntitiestrait no longer return errors and acceptsEntityMapper. So I think having a wrapper to just pass thingsEntityby value doesn't make sense. I would suggest to use regularHashMapand moveEntityMap::world_scopetoEntityMapper.What alternative(s) have you considered?
Implement
DerefandDerefMut.The text was updated successfully, but these errors were encountered: