Textures don't render correctly on Bistro

[Elabajaba]

Bevy version

b6ead2b

This appears to have started when assets v2 was merged.

Relevant system information

AdapterInfo { name: "AMD Radeon RX 6800 XT", vendor: 4098, device: 29631, device_type: DiscreteGpu, driver: "", driver_info: "", backend: Dx12 }

Also happens on linux vulkan on the same system.

What you did

Convert bistro (https://developer.nvidia.com/orca/amazon-lumberyard-bistro) to a gltf using blender, then view it with the scene viewer.

What went wrong

The textures aren't tiling correctly.

Additional information

The current incorrect texture rendering:

[Kanabenki]

What export settings did you use when exporting to gltf ? I tried reproducing by exporting as glb from the fbx with the default settings in blender. When loading the scene with the scene viewer from the bevy examples on 20ed3e0, the textures are properly tiling but I'm getting some extreme flickering from most of the meshes.

[Elabajaba]

Blender 3.6.4 is outputting broken gltfs that flicker (at least for bistro, tested in bevy and unreal 5.2). Blender 3.5.1 gltf exports work, but in bevy post assets v2 have broken texture rendering (at least for bistro).

[DGriffin91]

Same issue on sponza. This is using the same gltf file that I usually use for testing sponza that works correctly on 0.11

[superdump]

Looks like embedded textures have their sampler descriptor set but loading via uri doesn’t:

bevy/crates/bevy_gltf/src/loader.rs

Line 634 in 20ed3e0

image.sampler_descriptor = ImageSampler::Descriptor(texture_sampler(&gltf_texture));

bevy/crates/bevy_gltf/src/loader.rs

Line 1070 in 20ed3e0

address_mode_u: texture_address_mode(&gltf_sampler.wrap_s()),

that texture_sampler() function is where the address mode is set

So the two cases which handle uris need to use that function

To make the sampler descriptor