-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some warnings shown in nightly #10012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killercup
approved these changes
Oct 4, 2023
Weibye
approved these changes
Oct 4, 2023
james7132
approved these changes
Oct 5, 2023
regnarock
pushed a commit
to regnarock/bevy
that referenced
this pull request
Oct 13, 2023
# Objective Fix warnings: - #[warn(clippy::needless_pass_by_ref_mut)] - #[warn(elided_lifetimes_in_associated_constant)] ## Solution - Remove mut - add &'static ## Errors ```rust warning: this argument is a mutable reference, but not used mutably --> crates/bevy_hierarchy/src/child_builder.rs:672:31 | 672 | fn assert_children(world: &mut World, parent: Entity, children: Option<&[Entity]>) { | ^^^^^^^^^^ help: consider changing to: `&World` | = note: this is cfg-gated and may require further changes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default ``` ```rust warning: `&` without an explicit lifetime name cannot be used here --> examples/shader/post_processing.rs:120:21 | 120 | pub const NAME: &str = "post_process"; | ^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #115010 <rust-lang/rust#115010> = note: `#[warn(elided_lifetimes_in_associated_constant)]` on by default help: use the `'static` lifetime | 120 | pub const NAME: &'static str = "post_process"; | +++++++ ```
ameknite
added a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective Fix warnings: - #[warn(clippy::needless_pass_by_ref_mut)] - #[warn(elided_lifetimes_in_associated_constant)] ## Solution - Remove mut - add &'static ## Errors ```rust warning: this argument is a mutable reference, but not used mutably --> crates/bevy_hierarchy/src/child_builder.rs:672:31 | 672 | fn assert_children(world: &mut World, parent: Entity, children: Option<&[Entity]>) { | ^^^^^^^^^^ help: consider changing to: `&World` | = note: this is cfg-gated and may require further changes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default ``` ```rust warning: `&` without an explicit lifetime name cannot be used here --> examples/shader/post_processing.rs:120:21 | 120 | pub const NAME: &str = "post_process"; | ^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #115010 <rust-lang/rust#115010> = note: `#[warn(elided_lifetimes_in_associated_constant)]` on by default help: use the `'static` lifetime | 120 | pub const NAME: &'static str = "post_process"; | +++++++ ```
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Fix warnings: - #[warn(clippy::needless_pass_by_ref_mut)] - #[warn(elided_lifetimes_in_associated_constant)] ## Solution - Remove mut - add &'static ## Errors ```rust warning: this argument is a mutable reference, but not used mutably --> crates/bevy_hierarchy/src/child_builder.rs:672:31 | 672 | fn assert_children(world: &mut World, parent: Entity, children: Option<&[Entity]>) { | ^^^^^^^^^^ help: consider changing to: `&World` | = note: this is cfg-gated and may require further changes = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default ``` ```rust warning: `&` without an explicit lifetime name cannot be used here --> examples/shader/post_processing.rs:120:21 | 120 | pub const NAME: &str = "post_process"; | ^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #115010 <rust-lang/rust#115010> = note: `#[warn(elided_lifetimes_in_associated_constant)]` on by default help: use the `'static` lifetime | 120 | pub const NAME: &'static str = "post_process"; | +++++++ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Code-Quality
A section of code that is hard to understand or change
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix warnings:
Solution
Errors