Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_folder for non-default Asset Sources #10121

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

cart
Copy link
Member

@cart cart commented Oct 14, 2023

Objective

Fixes #10120

Solution

Assign the folder path source to loaded descendant asset paths in load_folder

@cart cart added the A-Assets Load files from disk to use for things like images, models, and sounds label Oct 14, 2023
@cart cart added this to the 0.12 milestone Oct 14, 2023
@cart cart added the C-Bug An unexpected or incorrect behavior label Oct 14, 2023
@anarelion
Copy link
Contributor

This fixes it for me.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 15, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 15, 2023
Merged via the queue into bevyengine:main with commit 3866b1c Oct 15, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
# Objective

Fixes bevyengine#10120

## Solution

Assign the folder path source to loaded descendant asset paths in
`load_folder`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

Fixes bevyengine#10120

## Solution

Assign the folder path source to loaded descendant asset paths in
`load_folder`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets in folders with multi asset sources can only use primary source
3 participants