Time: demote delta time clamping warning to debug #10145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
the
C-Usability
IceSentry
approved these changes
Oct 16, 2023
alice-i-cecile
approved these changes
Oct 16, 2023
alice-i-cecile
added
S-Ready-For-Final-Review
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective Time clamping happens consistently for apps that load non-trivial things. While this _is_ an indicator that we should probably try to move this work to a thread that doesn't block the Update, this is common enough (and unactionable enough) that I think we should demote it for now. ``` 2023-10-16T18:46:14.918781Z WARN bevy_time::virt: delta time larger than maximum delta, clamping delta to 250ms and skipping 63.649253ms 2023-10-16T18:46:15.178048Z WARN bevy_time::virt: delta time larger than maximum delta, clamping delta to 250ms and skipping 1.71611ms ``` ## Solution Change `warn` to `debug` for this message
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Time clamping happens consistently for apps that load non-trivial things. While this _is_ an indicator that we should probably try to move this work to a thread that doesn't block the Update, this is common enough (and unactionable enough) that I think we should demote it for now. ``` 2023-10-16T18:46:14.918781Z WARN bevy_time::virt: delta time larger than maximum delta, clamping delta to 250ms and skipping 63.649253ms 2023-10-16T18:46:15.178048Z WARN bevy_time::virt: delta time larger than maximum delta, clamping delta to 250ms and skipping 1.71611ms ``` ## Solution Change `warn` to `debug` for this message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Time clamping happens consistently for apps that load non-trivial things. While this is an indicator that we should probably try to move this work to a thread that doesn't block the Update, this is common enough (and unactionable enough) that I think we should demote it for now.
Solution
Change
warntodebugfor this message