Application lifetime events (suspend audio on Android) #10158
Conversation
alice-i-cecile
added
A-Audio
There was a problem hiding this comment.
Very useful fix, with good support for alternative audio backends. I like the straightforward lifetime events pattern, and I look forward to seeing how this evolves in the future.
Non-blocking, but does it make more sense to use a State rather than and Event for the Lifetime information? It feels like users may want to know about the current state, rather than just the transitions.
|
On most platforms, this is done by callbacks which translates more easily to events. Adding a state later if there's need for it should be easy enough. |
|
the code resuming audio is in the example code, and is not general. it uses |
examples/mobile/src/lib.rs
Outdated
| ) { | ||
| for event in lifetime_events.read() { | ||
| match event { | ||
| Lifetime::Suspended => music_controller.single().pause(), |
There was a problem hiding this comment.
Should we gate these only for Android builds?
There was a problem hiding this comment.
they will start to be useful on iOS with next version of winit, and they don't hurt for now
Co-Authored-By: Marco Buono <418473+coreh@users.noreply.github.com>
mockersf
added
the
S-Ready-For-Final-Review
| derive(serde::Serialize, serde::Deserialize), | ||
| reflect(Serialize, Deserialize) | ||
| )] | ||
| pub enum ApplicationLifetime { |
There was a problem hiding this comment.
Bikeshedding heavily here, but ApplicationLifetime seems to suggest this is not an event but a config option of some kind? ApplicationLifetimeEvent is more verbose, but more explicit in what it's denoting.
There was a problem hiding this comment.
I would prefer to avoid events called ...Event. The variants makes it clear enough what it is for me
) # Objective - Handle pausing audio when Android app is suspended ## Solution - This is the start of application lifetime events. They are mostly useful on mobile - Next version of winit should add a few more - When application is suspended, send an event to notify the application, and run the schedule one last time before actually suspending the app - Audio is now suspended too 🎉 https://github.com/bevyengine/bevy/assets/8672791/d74e2e09-ee29-4f40-adf2-36a0c064f94e --------- Co-authored-by: Marco Buono <418473+coreh@users.noreply.github.com>
) # Objective - Handle pausing audio when Android app is suspended ## Solution - This is the start of application lifetime events. They are mostly useful on mobile - Next version of winit should add a few more - When application is suspended, send an event to notify the application, and run the schedule one last time before actually suspending the app - Audio is now suspended too 🎉 https://github.com/bevyengine/bevy/assets/8672791/d74e2e09-ee29-4f40-adf2-36a0c064f94e --------- Co-authored-by: Marco Buono <418473+coreh@users.noreply.github.com>
Objective
Solution
audio.mp4