Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParamSets containing non-send parameters should also be non-send #10211

Merged
merged 5 commits into from
Oct 21, 2023
Merged

ParamSets containing non-send parameters should also be non-send #10211

merged 5 commits into from
Oct 21, 2023

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Oct 21, 2023 •
edited
Loading

Objective

Fix #10207

Solution

Mark a ParamSet's SystemMeta as non-send if any of its component parameters are non-send.

@JoJoJet JoJoJet added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events P-Crash A sudden unexpected crash labels Oct 21, 2023
alice-i-cecile
alice-i-cecile requested changes Oct 21, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a couple more test cases to the regression test, to cover cases where it's the first and not-first param that are non-send as well.

@JoJoJet
Copy link
Member Author

JoJoJet commented Oct 21, 2023

Like that?

alice-i-cecile
alice-i-cecile approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, those are the tests I was looking for. Looks great!

iiYese
iiYese approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@iiYese iiYese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 21, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 21, 2023
Merged via the queue into bevyengine:main with commit 0716922 Oct 21, 2023
22 checks passed
@JoJoJet JoJoJet deleted the param-set-non-send branch October 21, 2023 18:29
robtfm pushed a commit to robtfm/bevy that referenced this pull request Oct 23, 2023
@JoJoJet @robtfm
ParamSets containing non-send parameters should also be non-send (b…
e889743 
…evyengine#10211)

# Objective

Fix bevyengine#10207

## Solution

Mark a `ParamSet`'s `SystemMeta` as non-send if any of its component
parameters are non-send.
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@JoJoJet @ameknite
ParamSets containing non-send parameters should also be non-send (b…
0af0168 
…evyengine#10211)

# Objective

Fix bevyengine#10207

## Solution

Mark a `ParamSet`'s `SystemMeta` as non-send if any of its component
parameters are non-send.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@JoJoJet
ParamSets containing non-send parameters should also be non-send (b…
3d7f84f 
…evyengine#10211)

# Objective

Fix bevyengine#10207

## Solution

Mark a `ParamSet`'s `SystemMeta` as non-send if any of its component
parameters are non-send.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iiYese iiYese iiYese approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@hymm hymm hymm approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NonSendMut is allowed to run on the wrong thread when used in a ParamSet
5 participants
@JoJoJet @hymm @alice-i-cecile @mockersf @iiYese