Truncate attribute buffer data rather than attribute buffers #10270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing truncation code limits the number of attribute buffers to be less than or equal to the number of vertices. Instead the number of elements from each attribute buffer should be limited to the length of the shortest buffer as mentioned in the earlier warning.
rparrett
added
C-Bug
rparrett
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
I am surprised this hasn't caused any problems elsewhere... I guess we probably don't have any examples where there are more vertex attributes than vertices in a mesh?
This seems like an obvious good fix and holds up to some basic testing in generate_custom_mesh.rs.
rparrett
added
the
P-High
robtfm
approved these changes
Oct 28, 2023
IceSentry
added
the
S-Ready-For-Final-Review
JMS55
approved these changes
Oct 28, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
…ine#10270) Existing truncation code limits the number of attribute buffers to be less than or equal to the number of vertices. Instead the number of elements from each attribute buffer should be limited to the length of the shortest buffer as mentioned in the earlier warning. # Objective - Fixes bevyengine#10267 ## Solution - Moves the `.take()` from the outer loop of attribute buffers, to the inner loop of attribute values. ---
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…ine#10270) Existing truncation code limits the number of attribute buffers to be less than or equal to the number of vertices. Instead the number of elements from each attribute buffer should be limited to the length of the shortest buffer as mentioned in the earlier warning. # Objective - Fixes bevyengine#10267 ## Solution - Moves the `.take()` from the outer loop of attribute buffers, to the inner loop of attribute values. ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing truncation code limits the number of attribute buffers to be less than or equal to the number of vertices.
Instead the number of elements from each attribute buffer should be limited to the length of the shortest buffer as mentioned in the earlier warning.
Objective
Solution
.take()from the outer loop of attribute buffers, to the inner loop of attribute values.