Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve CursorIcon doc. #10289

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Slightly improve CursorIcon doc. #10289

merged 1 commit into from
Oct 28, 2023

Conversation

waywardmonkeys
Copy link
Contributor

Objective

  • When finding the CursorIcon doc, it should be easier to find out where to use it.
  • When saying it is partially copied from the browser, be more clear about the provenance and link to the spec document.

Solution

  • Link to the example code.
  • Link to the CSS3 UI spec document.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-UI Graphical user interfaces, styles, layouts, and widgets labels Oct 27, 2023
@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed A-UI Graphical user interfaces, styles, layouts, and widgets S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 27, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 28, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 28, 2023
Merged via the queue into bevyengine:main with commit 8eeb01e Oct 28, 2023
@waywardmonkeys waywardmonkeys deleted the slightly-improve-cursoricon-doc branch October 28, 2023 14:59
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@waywardmonkeys @ameknite
Slightly improve CursorIcon doc. (bevyengine#10289)
0c2e256 
# Objective

- When finding the `CursorIcon` doc, it should be easier to find out
where to use it.
- When saying it is partially copied from the browser, be more clear
about the provenance and link to the spec document.

## Solution

- Link to the example code.
- Link to the CSS3 UI spec document.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@waywardmonkeys
Slightly improve CursorIcon doc. (bevyengine#10289)
fb29f05 
# Objective

- When finding the `CursorIcon` doc, it should be easier to find out
where to use it.
- When saying it is partially copied from the browser, be more clear
about the provenance and link to the spec document.

## Solution

- Link to the example code.
- Link to the CSS3 UI spec document.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waywardmonkeys @james7132 @alice-i-cecile