ReadAssetBytesError::Io exposes failing path
#10450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Bug
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
alice-i-cecile
approved these changes
Nov 8, 2023
killercup
approved these changes
Nov 9, 2023
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Nov 14, 2023
|
@orph3usLyre CI failures look real; can you test this out locally and then push the changes? Once that's done I'm happy to merge this in :) |
killercup
approved these changes
Nov 16, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Addresses #[10438](bevyengine#10438) The objective was to include the failing path in the error for the user to see. ## Solution Add a `path` field to the `ReadAssetBytesError::Io` variant to expose the failing path in the error message. ## Migration Guide - The `ReadAssetBytesError::Io` variant now contains two named fields instead of converting from `std::io::Error`. 1. `path`: The requested (failing) path (`PathBuf`) 2. `source`: The source `std::io::Error` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Addresses #10438
The objective was to include the failing path in the error for the user to see.
Solution
Add a
pathfield to theReadAssetBytesError::Iovariant to expose the failing path in the error message.Migration Guide
ReadAssetBytesError::Iovariant now contains two named fields instead of converting fromstd::io::Error.path: The requested (failing) path (PathBuf)source: The sourcestd::io::Error