Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[derive(Reflect)] on GizmoConfig #10483

Merged
merged 2 commits into from
Nov 11, 2023
Merged

#[derive(Reflect)] on GizmoConfig #10483

merged 2 commits into from
Nov 11, 2023

Conversation

SludgePhD
Copy link
Contributor

No description provided.

@alice-i-cecile
Copy link
Member

These types should probably be registered too.

@SludgePhD
Copy link
Contributor Author

yeah, forgot about that

@SludgePhD SludgePhD force-pushed the reflect-gizmoconfig branch from 077d5bb to 9e80d86 Compare November 9, 2023 23:42
@jakobhellermann jakobhellermann mentioned this pull request Nov 10, 2023
Merged
@nicopap nicopap added this to the 0.13 milestone Nov 11, 2023
@nicopap nicopap added A-Reflection Runtime information about types A-Gizmos Visual editor and debug gizmos labels Nov 11, 2023
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 11, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 11, 2023
Merged via the queue into bevyengine:main with commit c505610 Nov 11, 2023
25 checks passed
@SludgePhD SludgePhD deleted the reflect-gizmoconfig branch November 11, 2023 21:44
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SludgePhD
#[derive(Reflect)] on GizmoConfig (bevyengine#10483)
ba876ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicopap nicopap nicopap approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
3 participants
@SludgePhD @alice-i-cecile @nicopap