-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load_untyped
to LoadContext
#10526
Conversation
Failing test doesn't seem to be related to this change. Have also via Cargo.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on board for this / the code is correct, but I do wonder about the utility of exposing this to AssetLoaders, as it would imply you are loading handles in assets that must later be resolved to the "final handle" by consumers of the asset.
Thank you for taking the time to review/approve and merge! If you want to know, my use case is I have custom ".bam(.txt)" files, or "Bevy Asset Manifest" assets. They are simple lists of different assets I want loaded together. In this case, the BAM asset itself doesn't really care about what the thing is that is being loaded, just that it is loaded. This triggers the asset event listeners that DO care about what is loaded (I have some assets that essentially only exist to be loaded and fed into a common resource), as well as allowing me to specify a bundle of assets to be "preloaded." |
# Objective Give us the ability to load untyped assets in AssetLoaders. ## Solution Basically just copied the code from `load`, but used `asset_server.load_untyped` instead internally. ## Changelog Added `load_untyped` method to `LoadContext`
# Objective Give us the ability to load untyped assets in AssetLoaders. ## Solution Basically just copied the code from `load`, but used `asset_server.load_untyped` instead internally. ## Changelog Added `load_untyped` method to `LoadContext`
Objective
Give us the ability to load untyped assets in AssetLoaders.
Solution
Basically just copied the code from
load
, but usedasset_server.load_untyped
instead internally.Changelog
Added
load_untyped
method toLoadContext