Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to configure FixedUpdate #10564

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

stepancheg
Copy link
Contributor

No description provided.

Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than before, two nits :)

crates/bevy_app/src/main_schedule.rs Outdated Show resolved Hide resolved
@@ -71,6 +71,9 @@ pub struct RunFixedUpdateLoop;
///
/// The exclusive `run_fixed_update_schedule` system runs this schedule.
/// This is run by the [`RunFixedUpdateLoop`] schedule.
///
/// Frequency of execution is configured by inserting `Time<Fixed>` resource, 64 Hz by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link to the time type with the generic? maybe as two links?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bevy_app does not depend on bevy_time. We can only link to docs.rs I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, didn't expect that, but makes sense. I don't think we need to link to it then :)

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Time Involves time keeping and reporting labels Nov 15, 2023
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 15, 2023
@alice-i-cecile
Copy link
Member

I'll let this sit until Monday if you wanna add more links <3

@@ -71,6 +71,9 @@ pub struct RunFixedUpdateLoop;
///
/// The exclusive `run_fixed_update_schedule` system runs this schedule.
/// This is run by the [`RunFixedUpdateLoop`] schedule.
///
/// Frequency of execution is configured by inserting `Time<Fixed>` resource, 64 Hz by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, didn't expect that, but makes sense. I don't think we need to link to it then :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 16, 2023
Merged via the queue into bevyengine:main with commit 1c5c972 Nov 16, 2023
22 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Time Involves time keeping and reporting C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants