Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example custom_asset_reader on wasm #10574

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix example custom_asset_reader on wasm #10574

merged 1 commit into from
Nov 16, 2023

Conversation

mockersf
Copy link
Member

Objective

  • Example custom_asset_reader fails to build in wasm
$ cargo build --profile release --target wasm32-unknown-unknown --example custom_asset_reader
   Compiling bevy v0.12.0 (/Users/runner/work/bevy-website/bevy-website)
error[E0432]: unresolved import `bevy::asset::io::file`
 --> examples/asset/custom_asset_reader.rs:7:9
  |
7 |         file::FileAssetReader, AssetReader, AssetReaderError, AssetSource, AssetSourceId,
  |

Solution

  • Wrap the platform default asset reader instead of the FileAssetReader

@mockersf mockersf added C-Examples An addition or correction to our examples A-Assets Load files from disk to use for things like images, models, and sounds O-Web Specific to web (WASM) builds labels Nov 15, 2023
@mockersf mockersf added this to the 0.12.1 milestone Nov 15, 2023
@cart cart added this pull request to the merge queue Nov 16, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2023
@cart cart added this pull request to the merge queue Nov 16, 2023
Merged via the queue into bevyengine:main with commit ce60027 Nov 16, 2023
25 checks passed
cart pushed a commit that referenced this pull request Nov 30, 2023
@mockersf @cart
fix example custom_asset_reader on wasm (#10574)
3877557 
# Objective

- Example `custom_asset_reader` fails to build in wasm
```
$ cargo build --profile release --target wasm32-unknown-unknown --example custom_asset_reader
   Compiling bevy v0.12.0 (/Users/runner/work/bevy-website/bevy-website)
error[E0432]: unresolved import `bevy::asset::io::file`
 --> examples/asset/custom_asset_reader.rs:7:9
  |
7 |         file::FileAssetReader, AssetReader, AssetReaderError, AssetSource, AssetSourceId,
  |  
```

## Solution

- Wrap the platform default asset reader instead of the
`FileAssetReader`
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
fix example custom_asset_reader on wasm (bevyengine#10574)
5888561 
# Objective

- Example `custom_asset_reader` fails to build in wasm
```
$ cargo build --profile release --target wasm32-unknown-unknown --example custom_asset_reader
   Compiling bevy v0.12.0 (/Users/runner/work/bevy-website/bevy-website)
error[E0432]: unresolved import `bevy::asset::io::file`
 --> examples/asset/custom_asset_reader.rs:7:9
  |
7 |         file::FileAssetReader, AssetReader, AssetReaderError, AssetSource, AssetSourceId,
  |  
```

## Solution

- Wrap the platform default asset reader instead of the
`FileAssetReader`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @cart