Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#![forbid(rustdoc::broken_intra_doc_links)] #10597

Closed
wants to merge 1 commit into from
Closed

#![forbid(rustdoc::broken_intra_doc_links)] #10597

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

Safer this way.

@hymm
Copy link
Contributor

hymm commented Nov 16, 2023

This should probably wait for #10011 and then use workspace lints.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Build-System Related to build systems or continuous integration labels Nov 16, 2023
@alice-i-cecile
Copy link
Member

On board with this, but swap it to a warn and do it at the workspace level like WrongShoe said :)

@stepancheg
Copy link
Contributor Author

swap it to a warn

It is warn by default. So when I run cargo doc, it just prints a warning which is too easy to overlook.

@mockersf
Copy link
Member

CI will already fail on doc warnings, no need to forbid it

@alice-i-cecile
Copy link
Member

Let's leave it as is then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepancheg @hymm @alice-i-cecile @mockersf