Re-export wgpu BufferAsyncError #10611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Nov 17, 2023
mockersf
approved these changes
Nov 20, 2023
mockersf
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective The `map_async` method involves a type `BufferAsyncError`: https://docs.rs/bevy/latest/bevy/render/render_resource/struct.BufferSlice.html#method.map_async This type is not re-exported in Bevy, so if a user wants to store a struct involving this type they have to add wgpu manually to their manifest. ## Solution - Re-export wgpu::BufferAsyncError --- ## Changelog ### Added - Re-export wgpu::BufferAsyncError Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com> Co-authored-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
map_asyncmethod involves a typeBufferAsyncError: https://docs.rs/bevy/latest/bevy/render/render_resource/struct.BufferSlice.html#method.map_asyncThis type is not re-exported in Bevy, so if a user wants to store a struct involving this type they have to add wgpu manually to their manifest.
Solution
Changelog
Added