Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use handles for queued scenes in SceneSpawner #10619

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

cart
Copy link
Member

@cart cart commented Nov 17, 2023

Objective

Fixes #10482

Solution

Store Handles instead of AssetIds for queued Scenes and DynamicScenes in SceneSpawner.

@cart cart added the A-Assets Load files from disk to use for things like images, models, and sounds label Nov 17, 2023
@cart cart added this to the 0.12.1 milestone Nov 17, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 17, 2023
@cart cart added this pull request to the merge queue Nov 18, 2023
Merged via the queue into bevyengine:main with commit 48d10e6 Nov 18, 2023
24 checks passed
cart added a commit that referenced this pull request Nov 30, 2023
Fixes #10482

Store Handles instead of AssetIds for queued Scenes and DynamicScenes in
SceneSpawner.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective

Fixes bevyengine#10482

## Solution

Store Handles instead of AssetIds for queued Scenes and DynamicScenes in
SceneSpawner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SceneSpawner::spawn_dynamic doesn't hold the handle after 0.12
4 participants