Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new event WindowOccluded from winit #10735

Merged
merged 1 commit into from
Nov 26, 2023
Merged

add new event WindowOccluded from winit #10735

merged 1 commit into from
Nov 26, 2023

Conversation

extrawurst
Copy link
Contributor

forward for bevy user to consume

Objective

Solution

  • pick up the winit event and forward it to a new EventWriter

Changelog

Added

  • new Event WindowOccluded added allowing to hook into WindowEvent::Occluded of winit

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@Nilirad Nilirad added A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on labels Nov 25, 2023
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Nov 26, 2023
@extrawurst
add new event WindowOccluded from winit
8c9c753 
forward for bevy user to consume
@extrawurst extrawurst force-pushed the forward-window-occluded branch from 667627d to 8c9c753 Compare November 26, 2023 14:59
alice-i-cecile
alice-i-cecile approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better docs, thank you!

@james7132 james7132 added this pull request to the merge queue Nov 26, 2023
Merged via the queue into bevyengine:main with commit 9849221 Nov 26, 2023
22 checks passed
@extrawurst extrawurst mentioned this pull request Mar 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
5 participants
@extrawurst @james7132 @alice-i-cecile @mockersf @Nilirad