Ran cargo fmt on benches crate
#10758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Style guide must've changed since the last time it was run.
ItsDoot
added
the
C-Code-Quality
rlidwka
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Yep. This is what we have to do, otherwise someone else is gonna run into this eventually.
Additionally, from the Bevy side, this should be checked by CI.
And from rustfmt side, it shouldn't touch irrelevant files in your PR. Unfortunately, feature request to do that is open over there for almost 7 years now. :(
Correct! I accidentally ran |
alice-i-cecile
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
benchescrate to match current Rust standards.Solution
cargo fmtin thebenchescrate.Notes
I accidentally came across this when working on the
Dropimplementation forCommandQueueand rather embarrassingly let it sneak into my PR there. I think it makes sense to ensure this crate is also well formatted to avoid it in the future.