Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bmp as a supported texture format #1081

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Conversation

ryanleecode
Copy link
Contributor

Adds bmp as a supported file extension and adds a test to ensure all file extensions in the EXTENSIONS array are valid.

@mockersf
Copy link
Member

Hello and welcome! 🖖

For it to work, you will also need to add a feature to enable bmp support of the image crate in the Cargo.toml of bevy_render

And then, the feature will also need to be added in the Cargo.toml of bevy itself and in the Cargo.toml of bevy_internal

That makes a lot of features to add, but it helps with compile time for people who don't need the feature...

Thank you!

@ryanleecode
Copy link
Contributor Author

Hi François! 🖖

Good catch! Added the fix.

@ryanleecode ryanleecode marked this pull request as ready for review December 17, 2020 18:12
@ryanleecode ryanleecode changed the title Add bmp as a supported file extension Add bmp as a supported texture format Dec 17, 2020
@Moxinilian Moxinilian added A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible labels Dec 18, 2020
@cart
Copy link
Member

cart commented Dec 23, 2020

Looks good to me. Thanks!

@cart cart merged commit acc29ec into bevyengine:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants