Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BindingType import warning #10818

Merged

Conversation

torsteingrindvik
Copy link
Contributor

@torsteingrindvik torsteingrindvik commented Nov 30, 2023

Objective

Fix this warning

warning: unused import: `BindingType`
  --> ...bevy/crates/bevy_pbr/src/render/mesh_view_bindings.rs:23:88
   |
23 |         BindGroup, BindGroupLayout, BindGroupLayoutEntry, BindGroupLayoutEntryBuilder, BindingType,
   |                                                                                        ^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Solution

  • Import via globstar

@JMS55
Copy link
Contributor

JMS55 commented Nov 30, 2023

Instead of this PR, can you please replace the import with:
render_resource::{binding_types::*, *}

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Nov 30, 2023
@torsteingrindvik torsteingrindvik force-pushed the cfg-assert-binding-type-use branch from cd100de to 59c481d Compare December 1, 2023 21:06
Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
@torsteingrindvik torsteingrindvik force-pushed the cfg-assert-binding-type-use branch from 59c481d to 11f0741 Compare December 1, 2023 21:06
@torsteingrindvik
Copy link
Contributor Author

Instead of this PR, can you please replace the import with: render_resource::{binding_types::*, *}

Clever, replaced PR with your suggestion.

@torsteingrindvik torsteingrindvik changed the title Only import BindingType on cfg debug assertions Fix BindingType import warning Dec 7, 2023
@JMS55 JMS55 requested a review from alice-i-cecile December 14, 2023 18:10
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 14, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 14, 2023
Merged via the queue into bevyengine:main with commit 16c5a4b Dec 14, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants