Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually check alignment in BlobVec test aligned_zst #10885

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Actually check alignment in BlobVec test aligned_zst #10885

merged 2 commits into from
Dec 13, 2023

Conversation

stepancheg
Copy link
Contributor

Do not rely on Miri.

@stepancheg stepancheg changed the title Actually check alignment BlobVec test aligned_zst Actually check alignment in BlobVec test aligned_zst Dec 5, 2023
@ItsDoot ItsDoot added A-ECS Entities, components, systems, and events P-Unsound A bug that results in undefined compiler behavior labels Dec 6, 2023
@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Dec 6, 2023
james7132
james7132 reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not rely on Miri.

I feel like this should be raised as a Miri bug if that's not being checked for, or if it's been acknowledged by the miri devs to be something they're not addressing, that should be linked in the PR description.

@stepancheg
Copy link
Contributor Author

I don't know whether Miri checks it or not. Probably it does. The point here, this test should check alignment even if this test is not running under Miri. Because it is convenient to just do cargo test -p bevy_ecs.

@james7132 james7132 enabled auto-merge December 13, 2023 02:20
@james7132 james7132 added this pull request to the merge queue Dec 13, 2023
Merged via the queue into bevyengine:main with commit 12a11e2 Dec 13, 2023
22 checks passed
@stepancheg stepancheg deleted the blob-vec-zst-align branch December 13, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

@rlidwka rlidwka rlidwka approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change P-Unsound A bug that results in undefined compiler behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stepancheg @rlidwka @james7132 @alice-i-cecile @ItsDoot