Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Window scale factor to f32 (adopted) #10897

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Change Window scale factor to f32 (adopted) #10897

merged 7 commits into from
Dec 14, 2023

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 6, 2023

Objective

Solution

@alice-i-cecile alice-i-cecile changed the title Fix pr 8942 Change Window scale factor to f32 (adopted) Dec 6, 2023
@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 6, 2023
@alice-i-cecile
Copy link
Member

What remains to be done before this can be taken out of draft? :)

@tygyh
Copy link
Contributor Author

tygyh commented Dec 7, 2023

What remains to be done before this can be taken out of draft? :)

It does not build and the CI fails. I published it as a draft for others to be able to look at it.

See this thread for discussion about the build issues https://discord.com/channels/691052431525675048/1181527271715119164

@tygyh tygyh marked this pull request as ready for review December 7, 2023 20:44
@tygyh
Copy link
Contributor Author

tygyh commented Dec 7, 2023

@alice-i-cecile Now it is ready for review.

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Dec 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@alice-i-cecile alice-i-cecile requested a review from JMS55 December 8, 2023 17:47
@alice-i-cecile alice-i-cecile mentioned this pull request Dec 8, 2023
Closed
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Dec 12, 2023
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 14, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 14, 2023
Merged via the queue into bevyengine:main with commit 720d6da Dec 14, 2023
25 checks passed
@tygyh tygyh deleted the fix-pr-8942 branch December 15, 2023 10:00
@eerii eerii mentioned this pull request Jan 17, 2024
Merged
@james7132 james7132 mentioned this pull request Mar 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@hymm hymm hymm approved these changes

@ickshonpe ickshonpe Awaiting requested review from ickshonpe

@JMS55 JMS55 Awaiting requested review from JMS55

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.
4 participants
@tygyh @alice-i-cecile @hymm @thmsgntz