Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport winit::platform::android::activity::* in bevy_winit #11011

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Reexport winit::platform::android::activity::* in bevy_winit #11011

merged 5 commits into from
Dec 19, 2023

Conversation

hecksmosis
Copy link
Contributor

Objective

Solution

  • Reexport winit::platform::android::activity::* in bevy_init

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in O-Android Specific to the Android mobile operating system C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 17, 2023
@JMS55
Copy link
Contributor

JMS55 commented Dec 17, 2023

Instead of a top-level export, maybe we want to scope it under a module? I don't have a preference either way I don't think.

@matiqo15
Copy link
Member

I agree with @JMS55, though it's fine either way.

@hecksmosis @mockersf
Update crates/bevy_winit/src/lib.rs
0a8f2c1 
Co-authored-by: François <mockersf@gmail.com>
@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 18, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2023
mockersf
mockersf requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also have to update the places where the AndroidApp was used

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 19, 2023
Merged via the queue into bevyengine:main with commit dc8fc6c Dec 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf requested changes

@matiqo15 matiqo15 matiqo15 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Usability A targeted quality-of-life change that makes Bevy easier to use O-Android Specific to the Android mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-export winit::platform::android::activity::* in bevy_winit
5 participants
@hecksmosis @JMS55 @matiqo15 @alice-i-cecile @mockersf