Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain OrthographicProjection.scale #11023

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Explain OrthographicProjection.scale #11023

merged 1 commit into from
Jan 8, 2024

Conversation

stepancheg
Copy link
Contributor

Alternative to #11022.

(Also remove "in world units", it is probably a mistake.)

@stepancheg stepancheg mentioned this pull request Dec 19, 2023
Closed
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Dec 19, 2023
@stepancheg
Copy link
Contributor Author

CC @doonv

doonv
doonv suggested changes Dec 20, 2023
View reviewed changes
crates/bevy_render/src/camera/projection.rs Outdated Show resolved Hide resolved
crates/bevy_render/src/camera/projection.rs Outdated Show resolved Hide resolved
@stepancheg stepancheg requested a review from doonv December 20, 2023 20:29
doonv
doonv approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@doonv doonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but someone else also mentioned a small improvement.

crates/bevy_render/src/camera/projection.rs Show resolved Hide resolved
@stepancheg stepancheg requested a review from doonv December 21, 2023 00:52
@stepancheg
Copy link
Contributor Author

I accidentally reset review accepted flag by @doonv.

@rparrett rparrett added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 8, 2024
Merged via the queue into bevyengine:main with commit 38ef170 Jan 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doonv doonv doonv approved these changes

@DanielJin21 DanielJin21 DanielJin21 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stepancheg @DanielJin21 @doonv @rparrett @alice-i-cecile