Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mul<f32> for ScalingMode #11030

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Mul<f32> for ScalingMode #11030

merged 1 commit into from
Jan 8, 2024

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Dec 19, 2023 •
edited
Loading

Complement to #11022: if OrthographicProjection.scale is removed, this can be used instead.

CC @doonv @Davier

@doonv
Copy link
Contributor

doonv commented Dec 19, 2023

This shouldn't be a seperate pull request, it should just be a part of #11022

@stepancheg
Copy link
Contributor Author

Might be useful even if #11022 rejected, so I created a separate PR.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Dec 19, 2023
@alice-i-cecile alice-i-cecile mentioned this pull request Dec 19, 2023
Closed
@doonv
Copy link
Contributor

doonv commented Dec 19, 2023

Ah fair enough.

@doonv
Copy link
Contributor

doonv commented Dec 19, 2023

If ScalingMode both handles the amount of scaling and the type (mode) of scaling. Maybe it should be renamed to something simpler like Scaling?

@stepancheg
Copy link
Contributor Author

Right. Or perhaps OrthographicProjectionScaling, to make it clear it has nothing to do with perspective projection. (But either options will be significant breaking change.)

@doonv
Copy link
Contributor

doonv commented Dec 19, 2023

Actually, I think OrthographicScaling would be the best name for this. Not too long, not too short.

@stepancheg stepancheg requested a review from doonv December 20, 2023 19:31
doonv
doonv approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@doonv doonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Davier
Copy link
Contributor

Davier commented Dec 21, 2023

Do you think we should have Div and DivAssign?

@doonv
Copy link
Contributor

doonv commented Dec 21, 2023

Do you think we should have Div and DivAssign?

Yeah, why not.

@stepancheg
Copy link
Contributor Author

Added Div and DivAssign.

@rparrett rparrett added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 7, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 8, 2024
Merged via the queue into bevyengine:main with commit 8d9a0a8 Jan 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doonv doonv doonv approved these changes

@Davier Davier Davier approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stepancheg @doonv @Davier @rparrett @alice-i-cecile