Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add approx feature to bevy_math #11176

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Add approx feature to bevy_math #11176

merged 2 commits into from
Jan 2, 2024

Conversation

Jondolf
Copy link
Contributor

@Jondolf Jondolf commented Jan 2, 2024

Objective

bevy_math re-exports Glam, but doesn't have a feature for enabling approx for it. Many projects (including some of Bevy's own crates) need approx, and it'd be nice if you didn't have to manually add Glam to specify the feature for it.

Solution

Add an approx feature to bevy_math.

alice-i-cecile
alice-i-cecile requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful to expose, but needs a comment.

crates/bevy_math/Cargo.toml Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations labels Jan 2, 2024
@james7132 james7132 added this pull request to the merge queue Jan 2, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 2, 2024
Merged via the queue into bevyengine:main with commit 536a7bd Jan 2, 2024
27 checks passed
@Jondolf Jondolf deleted the glam-approx branch January 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jondolf @james7132 @alice-i-cecile