Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made the remaining types from bevy_ui to reflect the Default trait if… #11199

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Made the remaining types from bevy_ui to reflect the Default trait if… #11199

merged 3 commits into from
Jan 3, 2024

Conversation

Ato2207
Copy link
Contributor

@Ato2207 Ato2207 commented Jan 3, 2024

Objective

Solution

  • Made the remaining types from bevy_ui that do not reflect the Default trait to do it if possible.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

alice-i-cecile
alice-i-cecile approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much. Welcome aboard!

Merging as trivial.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types A-UI Graphical user interfaces, styles, layouts, and widgets and removed A-Reflection Runtime information about types labels Jan 3, 2024
@alice-i-cecile alice-i-cecile marked this pull request as ready for review January 3, 2024 17:51
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 3, 2024
auto-merge was automatically disabled January 3, 2024 18:04

Head branch was pushed to by a user without write access

@Ato2207 Ato2207 mentioned this pull request Jan 3, 2024
Closed
@james7132 james7132 added this pull request to the merge queue Jan 3, 2024
Merged via the queue into bevyengine:main with commit 3f535d5 Jan 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some types in bevy_ui do not reflect the Default trait
3 participants
@Ato2207 @james7132 @alice-i-cecile