Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example showcase patches: use default instead of game mode for desktop #11250

Merged

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 7, 2024

Objective

Solution

  • Patch desktop mode in example showcase to use default mode which is always Continuous

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Jan 7, 2024
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI #11227 didn't change the wait behavior, it just added a comment describing the already-existing behavior, which predates #11227 and #10702.

However, #11227 did change the update logic to rely on RedrawRequested window events. I'm not sure if this works with whatever we are using for testing.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 8, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 8, 2024
Merged via the queue into bevyengine:main with commit 371cd69 Jan 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants