Use Direction3d for gizmos.circle normal #11422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Could you use a Direction3d instead of a Vec3 so that it doesn't't have to be normalised? http://dev-docs.bevyengine.org/bevy/prelude/primitives/struct.Direction3d.html
matiqo15
added
C-Usability
|
Sure! Gave that a go. This does slightly conflict with @alice-i-cecile comment in #11401 though. Maybe callees using Direction3d::new(vec).unwrap_or(Direction3d::Y) isn't too bad. Maybe could be worth having a Direction3d::new_or(vec, Direction3d::Y) ? Not sure. |
|
I prefer the type-safe validation to my suggestion linked :) |
alice-i-cecile
approved these changes
Jan 21, 2024
|
@rodolphito review? |
mockersf
approved these changes
Jan 21, 2024
ArthurBrussee
changed the title
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix weird visuals when drawing a gizmo with a non-normed normal.
Fixes #11401
Solution
Just normalize right before we draw. Could do it when constructing the builder but that seems less consistent.
Changelog
Migration Guide
Direction3d::new(vec).unwrap_or(default)or potentiallyDirection3d::new_unchecked(vec)if you know your vec is definitely normalized.