-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TypeUuid #11497
Remove TypeUuid #11497
Conversation
I may have been a bit overzealous adding a second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we're removing this without marking it deprecated first, but I'm OK with removing it cold-turkey as there should be nothing interacting with it anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been nice to have first made it #[deprecated]
, but I don't think the migration should be too bad in most cases— assuming the user isn't already on 0.12.
@AxiomaticSemantics Could you update the Migration Guide to give users a bit more details on how this is done? Maybe a before/after snippet? |
I asked on discord, you thought it was, I was going to ask about this, nothing seemed to reference, but i did also notice it wasn't marked as such. Up to SME/maintainers I guess, seems nothing in the previous guides mention migrating away from it in favour of TypePath. |
If you'd rather mark it for now, this can hold off until release. |
My preference is to remove it outright: there's nothing connected to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with the #[rustfmt::skip]
? Are they needed? I have a pretty strong preference to remove them unless there's a good reason to have them.
I was getting import conflicts with serde and super::serde in the tests, the |
i think i also had this at one point, can't remember the fix. are you getting the errors through rust-analyzer or through a cli command? |
I noticed the errors becasuse bevy's CI was failing, no RA in the mix here all cargo invocations. ```error[E0432]: unresolved imports error[E0432]: unresolved imports error[E0659]: |
# Objective TypeUuid is deprecated, remove it. ## Migration Guide Convert any uses of `#[derive(TypeUuid)]` with `#[derive(TypePath]` for more complex uses see the relevant [documentation](https://docs.rs/bevy/latest/bevy/prelude/trait.TypePath.html) for more information. --------- Co-authored-by: ebola <dev@axiomatic>
Objective
TypeUuid is deprecated, remove it.
Migration Guide
Convert any uses of
#[derive(TypeUuid)]
with#[derive(TypePath]
for more complex uses see the relevant documentation for more information.