Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump dev-docs pages actions" #11502

Closed
wants to merge 1 commit into from

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jan 24, 2024

Objective

Solution

  • Revert commit 11e4386 to allow time for further investigation.

This commit was originally my pull request, but I have no idea why it broke. Unlike the error text, the artifact is less than 10 GB large. I don't believe it contains any links, but I'll need to check.

image

@BD103
Copy link
Member Author

BD103 commented Jan 24, 2024

This appears to be some sort of internal Github issue. (See actions/deploy-pages#284). It appears to be fixed, which is why I'm unsure why it's happening again. Perhaps the version tag needs to be pinned to the patch version?

We could additionally add actions: read to the permissions, but that really shouldn't be necessary. I don't see how Github Actions could be pulling in an old version.

@mockersf
Copy link
Member

#11507 is a potential fix but can only be tested before merging this one

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Build-System Related to build systems or continuous integration labels Jan 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2024
# Objective

- Try to fix deploying docs in CI
- Alternative to #11502

## Solution

- The only issue I could find is the lock file with invalid permissions,
try to remove it
- upload action was doing permissions cleanup in v1, that was removed in
v2. we're now using v3
@matiqo15
Copy link
Member

Fixed by #11507

@matiqo15 matiqo15 closed this Jan 24, 2024
@BD103 BD103 deleted the revert-dev-docs branch January 24, 2024 18:44
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
# Objective

- Try to fix deploying docs in CI
- Alternative to bevyengine#11502

## Solution

- The only issue I could find is the lock file with invalid permissions,
try to remove it
- upload action was doing permissions cleanup in v1, that was removed in
v2. we're now using v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants