-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shader UI #1158
Shader UI #1158
Conversation
Ok this is really cool 😄 Huge step forward in usability. Assorted thoughts:
|
I don't have much to say on most of these points, but for the last one I'd rather not have an extra system shoveling data into a different type. An alternative I considered is an |
Yeah it wouldn't be an extra system. It would be something more along the lines of RenderResourcesNode taking Into instead of RenderResources. Imo |
Hmm, how about |
I think I'd prefer it if we made RenderResourcesNode take |
Semi-related: #1208 (comment) |
The code in this PR is rather old, and implementation very much less-than-ideal, so I'm closing this PR :) |
This PR implements Overflow::Hidden, rounded corners and borders by extending the UI fragment shader. There are various bugs: anti-aliasing is broken for rounded overflows, overflow mask randomly shifts 1px up or down on certain node widths and text is entirely ignored, but its ready enough to talk over.