Naive garbage collection (Adopted) #11582
Conversation
There was a problem hiding this comment.
Awesome! Could you add doc comments to all of the new methods? The ones that were already added are a good template.
Additionally it appears that the CI is failing because the internal storage of certain structs have changed. You may need to update the respective functions to reflect these changes.
| /// Shrinks the backing storage for the [`BlobVec`] such that the `len == capacity`. | ||
| /// | ||
| /// This runs in `O(n)` time and may require reallocating backing buffer. | ||
| pub fn shrink_to_fit(&mut self) { |
There was a problem hiding this comment.
Could you add a test to this method, since everything else seems to depend on this? Some good things to test:
- Popping items from a
BlobVecthen shrinking - Shrinking a
BlobVecwith a capacity of 0 - Shrinking a
BlobVecwith a capacity >= 1 but a length of 0
alice-i-cecile
added
C-Feature
| let current_layout = | ||
| array_layout(&self.item_layout, self.capacity).expect("array layout should be valid"); | ||
| self.data = if self.len == 0 { | ||
| unsafe { |
There was a problem hiding this comment.
This needs a safety comment, as does the realloc below. If you need a reference, the safety comments on the allocation functions in grow_exact should be pretty close to the ones we should use here.
| @@ -323,6 +323,12 @@ impl ComponentSparseSet { | |||
| } | |||
| } | |||
|
|
|||
| pub fn shrink_to_fit(&mut self) { | |||
There was a problem hiding this comment.
This should probably have a doc comment as it's actually usable outside of bevy_ecs.
Objective
Solution