Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a doctest example for EntityMapper #11583

Merged

Conversation

cBournhonesque
Copy link
Contributor

@cBournhonesque cBournhonesque commented Jan 28, 2024

Objective

Fixes: #11549

Add a doctest example of what a custom implementation of an EntityMapper would look like.

(need to wait until #11428 is merged)

@cBournhonesque cBournhonesque changed the title Cb/simple entity mapper doc test Add a doctest example for EntityMapper Jan 28, 2024
@cBournhonesque cBournhonesque requested a review from Shatur January 28, 2024 19:30
@alice-i-cecile
Copy link
Member

Merging the previous PR, which should make the diff much cleaner momentarily.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation labels Jan 28, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 28, 2024
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 29, 2024
Merged via the queue into bevyengine:main with commit b17d42d Jan 29, 2024
22 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
# Objective

Fixes: bevyengine#11549 

Add a doctest example of what a custom implementation of an
`EntityMapper` would look like.

(need to wait until bevyengine#11428 is
merged)

---------

Co-authored-by: Charles Bournhonesque <cbournhonesque@snapchat.com>
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a simple EntityMapper struct for use in networking
5 participants