-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase intensity of point light in async_compute
example
#11857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of the PR should probably be something like "Increase the intensity of the PointLight
in the async_compute
example" since the light is already spawned (pedantic, I know)
async_compute
exampleasync_compute
example
No, I agree. Since the PR titles get put into the patch notes, its best to be specific about that kind of thing. Changed! c: |
Rebased onto main. I tried switching from a hardcoded illuminance to |
Point lights output in lumens, not lux. Lumens is the total amount of light emitted by a light, while lux is the amount of light an object is recieving. |
Oh, that makes sense why it didn't work. 😆 |
Looks much better. @cart has been poking at this: I'll let him decide what to do to avoid creating subtle conflicts. |
As per #11868 the new default intensity for |
Objective
async_compute
is very dark, lacking in detail.Solution
PointLight
from it's default 800 lumens to 1,000,000 lumens.Showcase
Before:
After:
Changelog
async_compute
example.