Overwrite gizmo group in insert_gizmo_group
#11860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Bug
pablo-lua
approved these changes
Feb 14, 2024
tim-blackbird
approved these changes
Feb 14, 2024
tim-blackbird
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I tried using
insert_gizmo_groupto configure my physics gizmos in a bevy_xpbd example, but was surprised to see that nothing happened. I found out that the method does not overwrite gizmo groups that have already been initialized (withinit_gizmo_group). This is unexpected, since methods likeinsert_resourcedo overwrite.Solution
Insert the configuration even if it has already been initialized.