bevy_ecs address trivial cases of unsafe_op_in_unsafe_fn
#11861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 14, 2024
alice-i-cecile
added
A-ECS
BD103
approved these changes
Feb 14, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Waiting for James to take a look before merging. |
doonv
approved these changes
Feb 14, 2024
james7132
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Overall, I think this is a step in the right direction given how dense some of the unsafe code is in bevy_ecs. However, I lament how it impacts end-to-end readabilty though given that some of these functions are nothing but unsafe, all the way through.
cargo geiger is going to explode on bevy_ecs from this PR though.
Co-authored-by: James Liu <contact@jamessliu.com>
Co-authored-by: James Liu <contact@jamessliu.com>
Co-authored-by: James Liu <contact@jamessliu.com>
unsafe block is a syntactic salt to force the developer to be more careful when making changes to unsafe code. Since it is a human's responsibility to ensure the safety rules, IMHO, it's worth it to pay the cost of readability in exchange for having a well-documented code. |
alice-i-cecile
removed
the
S-Ready-For-Final-Review
james7132
approved these changes
Feb 21, 2024
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Feb 22, 2024
…e#11861) # Objective - Part of bevyengine#11590 - Fix `unsafe_op_in_unsafe_fn` for trivial cases in bevy_ecs ## Solution Fix `unsafe_op_in_unsafe_fn` in bevy_ecs for trivial cases, i.e., add an `unsafe` block when the safety comment already exists or add a comment like "The invariants are uphold by the caller". --------- Co-authored-by: James Liu <contact@jamessliu.com>
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…e#11861) # Objective - Part of bevyengine#11590 - Fix `unsafe_op_in_unsafe_fn` for trivial cases in bevy_ecs ## Solution Fix `unsafe_op_in_unsafe_fn` in bevy_ecs for trivial cases, i.e., add an `unsafe` block when the safety comment already exists or add a comment like "The invariants are uphold by the caller". --------- Co-authored-by: James Liu <contact@jamessliu.com>
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…e#11861) # Objective - Part of bevyengine#11590 - Fix `unsafe_op_in_unsafe_fn` for trivial cases in bevy_ecs ## Solution Fix `unsafe_op_in_unsafe_fn` in bevy_ecs for trivial cases, i.e., add an `unsafe` block when the safety comment already exists or add a comment like "The invariants are uphold by the caller". --------- Co-authored-by: James Liu <contact@jamessliu.com>
NiseVoid
pushed a commit
to NiseVoid/bevy
that referenced
this pull request
Jul 8, 2024
…e#11861) - Part of bevyengine#11590 - Fix `unsafe_op_in_unsafe_fn` for trivial cases in bevy_ecs Fix `unsafe_op_in_unsafe_fn` in bevy_ecs for trivial cases, i.e., add an `unsafe` block when the safety comment already exists or add a comment like "The invariants are uphold by the caller". --------- Co-authored-by: James Liu <contact@jamessliu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
unsafe_op_in_unsafe_fnlint #11590unsafe_op_in_unsafe_fnfor trivial cases in bevy_ecsSolution
Fix
unsafe_op_in_unsafe_fnin bevy_ecs for trivial cases, i.e., add anunsafeblock when the safety comment already exists or add a comment like "The invariants are uphold by the caller".