-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asset loader registration warning #11870
Fix asset loader registration warning #11870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this should be hidden behind a feature, but there are many things that should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple change that resolves a problem I was facing earlier. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! This also fixes #11881.
Objective
When registering and preregistering asset loaders, there would be a
warn!
if multiple asset loaders use a given extension, and aninfo!
if multiple asset loaders load the same asset type. Since both of these situations are individually fine, it was decided that these messages should be removed.Solution
Replace both of these messages with a new
warn!
that notes that if multiple asset loaders share the same asset type and share extensions, that the loader must be specified in the.meta
file for those assets in order to solve the ambiguity. This is a more useful message, since it notes when a user must take special action / consideration.