Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ui Image slicing #12047

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

ManevilleF
Copy link
Contributor

Objective

Fixes #11944

Solution

#11600 made an incorrect assumption on what UiImageSize does, removing its usage in slicing fixes the problem

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Feb 22, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13.1 milestone Feb 22, 2024
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 22, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 23, 2024
Merged via the queue into bevyengine:main with commit fa17406 Feb 23, 2024
26 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective

Fixes bevyengine#11944

## Solution

bevyengine#11600 made an incorrect assumption on what `UiImageSize` does, removing
its usage in slicing fixes the problem
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 26, 2024
# Objective

Fixes bevyengine#11944

## Solution

bevyengine#11600 made an incorrect assumption on what `UiImageSize` does, removing
its usage in slicing fixes the problem
mockersf pushed a commit that referenced this pull request Feb 27, 2024
# Objective

Fixes #11944

## Solution

#11600 made an incorrect assumption on what `UiImageSize` does, removing
its usage in slicing fixes the problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9-slice sprite is behaving weirdly on ImageBundle
3 participants